[SPARK-3485][SQL] Use GenericUDFUtils.ConversionHelper for Simple UDF type conversions#2407
[SPARK-3485][SQL] Use GenericUDFUtils.ConversionHelper for Simple UDF type conversions#2407adrian-wang wants to merge 2 commits intoapache:masterfrom
Conversation
|
test this please. |
|
QA tests have started for PR 2407 at commit
|
|
QA tests have finished for PR 2407 at commit
|
|
We may need to coordinate this with #2241, but otherwise I agree this is much cleaner than before. Thanks for looking into this! |
|
Can you maybe change the title to something like |
|
Thanks for referencing pr 2241 here, while I think this should be reviewed first, and will make 2241 simpler, as well as getting |
|
I add a test case to this file, the current master will fail the case because we missed |
|
QA tests have started for PR 2407 at commit
|
|
QA tests have finished for PR 2407 at commit
|
|
+1, LGTM. I think this can go first, as it's simpler and cleaner (maybe fixed some unknown bugs), besides, it blocks the #2344. |
|
Thanks! I've merged this to master. |
This is just another solution to SPARK-3485, in addition to PR #2355
In this patch, we will use ConventionHelper and FunctionRegistry to invoke a simple udf evaluation, which rely more on hive, but much cleaner and safer.
We can discuss which one is better.